1/14 Opscode Code Review


#1

To Merge:

  • CHEF-1761: Change signal TERM to quit after the running jobs are finished

Closed:

  • CHEF-3022: rpm upgrade of chef-full omnibus rpm package kills symlinks in /usr/bin
    This is no longer needed as Ruby Omnibus fixed the issue

Re-opened:

  • CHEF-972: resource action should have higher precedence than only_if/not_if
    Comments added to the Jira ticket

  • CHEF-3471: knife bootstrap of a Solaris 10 host is an immediate failure
    The lines using awk NF should be removed rather than changed as they are no longer needed.

  • CHEF-3068: Chef resources display incorrectly in log files on windows due to splitting on ':'
    A comment explaining the regular expression and providing an example needs to be added.

  • CHEF-3676: Add copy/move actions to the file resource
    Several code/style comments were added to the pull request on GitHub.

  • CHEF-3446: Chef makes various assumptions which are incorrect when modifying users on Solaris and OpenSolaris forks
    Several code/style comments were added to the pull request on GitHub.


Paul Mooring
Systems Engineer and Customer Advocate