1/29 Code Review Part 2


#1

Merge:
CHEF-4680 - Avoiding raising subversion passwords in exceptions
COOK-4169 - Add the possibility to specify “options” for the
required-gems installation procedure in the chef-client cookbook
COOK-4097 - default[“tomcat”][“keytool”] is set to non-existent file
on Debian/Ubuntu
COOK-4186 - Upgrade_package concatenates an empty version string
when version is not set or is empty.
COOK-2935 - Type Error in mount_volumes
COOK-4264 - Add node[‘ark’][‘package_dependencies’] to allow tuning packages.
COOK-4095 - Explicit libpq-dev installation in postgresql::ruby

Other:
CHEF-4962 - knife ssh to use cloud ssh port attribute if available
Reopened - Standardize on node[:cloud][:public_ssh_port]
COOK-4231 - user_manage fails for user with ssh_key and no specified gid.
Reopened - Look up the group using the Etc module


Bryan McLellan | chef | software engineer
© 206.607.7108 | (t) @btmspox | (www) http://getchef.com


#2

Hi All,

This is in reference to CHEF-4962 “knife ssh to use cloud ssh port attribute if available”

What is your desired priority of the node attribute? The current order is:

config[:ssh_port] #cli option
Chef::Config[:knife][:ssh_port] # knife.rb
ssh_config[:port] # Net::SSH.configuration_for(host)

My proposal is:

config[:ssh_port]
Chef::Config[:knife][:ssh_port]
node[:cloud][:public_ssh_port]
ssh_config[:port]

Thanks!
Jeff

https://tickets.opscode.com/browse/CHEF-4962


Date: Wed, 29 Jan 2014 16:54:33 -0500
From: btm@getchef.com
To: chef-dev@lists.opscode.com
Subject: [chef-dev] 1/29 Code Review Part 2

Merge:
CHEF-4680 - Avoiding raising subversion passwords in exceptions
COOK-4169 - Add the possibility to specify “options” for the
required-gems installation procedure in the chef-client cookbook
COOK-4097 - default[“tomcat”][“keytool”] is set to non-existent file
on Debian/Ubuntu
COOK-4186 - Upgrade_package concatenates an empty version string
when version is not set or is empty.
COOK-2935 - Type Error in mount_volumes
COOK-4264 - Add node[‘ark’][‘package_dependencies’] to allow tuning packages.
COOK-4095 - Explicit libpq-dev installation in postgresql::ruby

Other:
CHEF-4962 - knife ssh to use cloud ssh port attribute if available
Reopened - Standardize on node[:cloud][:public_ssh_port]
COOK-4231 - user_manage fails for user with ssh_key and no specified gid.
Reopened - Look up the group using the Etc module


Bryan McLellan | chef | software engineer
© 206.607.7108 | (t) @btmspox | (www) http://getchef.com