11/6 Opscode Code Review


#1

Merge:
CHEF-3267 - webui status page doesn’t respect environment selection
COOK-3424 - Haproxy cookbook attempts to alter an immutable attribute
COOK-1695 - python_pip: Timeout value not passed to pip
COOK-3841 - Jenkins node home directory not set when using jnlp
COOK-3829 - Jenkins node needs an option to ignore SSL certificates
COOK-3823 - Upgrade to JDK 7u45-b18
COOK-1689 - The perl package name should be configurable
COOK-3854 - Capability with mac_os_x: ‘/bin/chown’ - No such file or directory
COOK-3820 - Fixed deprecated includes
COOK-3857 - java::windows should not unescape the url for java installer exe
COOK-3827 - chef-client cookbook to configure log rotating for windows
COOK-3858 - some of the root user passwords are not updated
COOK-3694 - Jenkins should support creation of jenkins (admin) user
COOK-1740 - Joyent SmartOS support for Postgresql Cookbook
COOK-3705 - Add init.d script with LSB style
COOK-3194 - Deploy java application with no/internal context
COOK-3672 - Nginx should support the gzip_static option
COOK-2465 - Add a compile and settings optional recipe.
COOK-3842 - Change test-kitchen support in Nagios cookbook to use chef-zero
COOK-3488 - set alternatives for IBM JDK
COOK-3863 - Add recipe for mod_jk

Other:
OHAI-480 - Ohai should look at “local” table for v6 routes
Reopened - Needs tests, a rebase, switch to shell_out
CHEF-4421 - Improve “No cookbook found” error message
Reopened - Needs to error only on all cookbooks
CHEF-2418 - ‘knife ssh’ should prompt for user password
Reviewed - There is a complex set of unwritten requirements here
COOK-3370 - Don’t install the tomcat manager apps package if we’re
not going to use it
Reviewed - Sean O. will fix this in a refactor
COOK-3714 - Powershell features provider and delete support.
Reviewed - Adam E. will respond to this PR


Bryan McLellan | opscode | technical program manager, open source
© 206.607.7108 | (t) @btmspox | (b) http://blog.loftninjas.org


#2

Bryan,

How soon after something is marked as “Fix Reviewed” should we expect a
merge? Still waiting on a merge for COOK-3823, but it looks like others are
in the same state, so I don’t think this one was overlooked.

On Wed, Nov 6, 2013 at 1:55 PM, Bryan McLellan btm@opscode.com wrote:

Merge:
CHEF-3267 - webui status page doesn’t respect environment selection
COOK-3424 - Haproxy cookbook attempts to alter an immutable attribute
COOK-1695 - python_pip: Timeout value not passed to pip
COOK-3841 - Jenkins node home directory not set when using jnlp
COOK-3829 - Jenkins node needs an option to ignore SSL certificates
COOK-3823 - Upgrade to JDK 7u45-b18
COOK-1689 - The perl package name should be configurable
COOK-3854 - Capability with mac_os_x: ‘/bin/chown’ - No such file or
directory
COOK-3820 - Fixed deprecated includes
COOK-3857 - java::windows should not unescape the url for java installer
exe
COOK-3827 - chef-client cookbook to configure log rotating for windows
COOK-3858 - some of the root user passwords are not updated
COOK-3694 - Jenkins should support creation of jenkins (admin) user
COOK-1740 - Joyent SmartOS support for Postgresql Cookbook
COOK-3705 - Add init.d script with LSB style
COOK-3194 - Deploy java application with no/internal context
COOK-3672 - Nginx should support the gzip_static option
COOK-2465 - Add a compile and settings optional recipe.
COOK-3842 - Change test-kitchen support in Nagios cookbook to use
chef-zero
COOK-3488 - set alternatives for IBM JDK
COOK-3863 - Add recipe for mod_jk

Other:
OHAI-480 - Ohai should look at “local” table for v6 routes
Reopened - Needs tests, a rebase, switch to shell_out
CHEF-4421 - Improve “No cookbook found” error message
Reopened - Needs to error only on all cookbooks
CHEF-2418 - ‘knife ssh’ should prompt for user password
Reviewed - There is a complex set of unwritten requirements here
COOK-3370 - Don’t install the tomcat manager apps package if we’re
not going to use it
Reviewed - Sean O. will fix this in a refactor
COOK-3714 - Powershell features provider and delete support.
Reviewed - Adam E. will respond to this PR


Bryan McLellan | opscode | technical program manager, open source
© 206.607.7108 | (t) @btmspox | (b) http://blog.loftninjas.org