5/6 Opscode Cookbook Code Review


#1

Ohai Chefs,

Below are the notes from today’s Cookbook Code Review. As part of
Joshua’s previous statement about focusing on cookbook stability, we
spent the majority of the time triaging bugs with fixes provided.

If a bug you are interested got marked as “Minor”, please know that we
still care about the bug and your fix. As we integrate severity
into our workflow, we will get better at being more consistent in how
bugs are categorized.

When filing bugs you can help us better determine severity by
providing a clear description of the consequences of the problem you
are describing and the likelihood of hitting the bug.

Cheers,

Steven

========

  • To Merge
  • COOK-2592 fail2ban: Update jail file template to match current config
    file
  • COOK-2885 Improvements for apt cache server search
  • COOK-2797 Contrib extension contianing ‘-’ fails to load.
  • Close
  • COOK-1674 Add Windows support to the NTP cookbook

    This shouldn’t be in the ntp cookbook. w32time cookbook.

  • COOK-2729 windows helper should use URI rather than regex and bare string

    Already merged and released in 1.8.10

  • Reopen
  • COOK-2828

    It would be better if we figured out why the service resource
    doesn’t stop the service and fix that. If we really need the
    execute resource, let’s remove the code rather than comment it out.
    Also, it should use the service_name attribute rather than
    hardcoding the services name.


Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key