7/11 Opscode Code Review


#1

Hey Chefs. We’ll be tidying up Chef 10.14.0 and cutting a release
candidate soon. I haven’t heard of any regressions in 10.12.0, so let
me know if anything knocked you over please.

We’ve proposed expanding the “depends” DSL to take an optional
platform_family requirement, e.g.:

depends “windows”, "windows"
depends “apt”, “debian”

Any thoughts on that? Are we missing uses cases? You can follow up on
CHEF-3282 [1].

To merge:
CHEF-3092 - knife cookbook upload -a should batch uploads
CHEF-3178 - cron provider does not support month names and weekday names
CHEF-3254 - Run garbage collector before sleeping
CHEF-3280 - Permit chef to run solr searches with @ in terms
CHEF-3273 - Webui returning “undefined method `empty?’ for
nil:NilClass” on invalid files
COOK-811 - Windows package provider does not pass through a timeout attribute
COOK-1296 - move build-essential installation to compile-time and
platform_family-ize it
COOK-1136 - Runit cookbook doesn’t set owner/group for the supervise directory
COOK-1291 - Snapshot retention policy confusing
COOK-1298 - Re-factor NTP recipe into a reference cookbook for testing
COOK-1237 - Mysql cookbook downloads windows cookbook which causes
issues on other systems

Other:
KNIFE_EC2-67 - Add an option to bind instance to elastic ip prior to bootstrap
Reopened - Ask the mailing list
KNIFE_EC2-68 - Add a family of commands for manipulating elastic ip addresses.
Closed - Wontfix, as a policy knife-ec2 shouldn’t merely duplicate
ec2-tools functionality
KNIFE_EC2-69 - Adding ssh_gateway support for tunneling in VPCs
Reopened - Crufty commit, upfactor to knife bootstrap
CHEF-3270 - Permit chef to be run in empty env
Reopened - Add a regression test
COOK-543 - php.ini template should be configurable
Reopened - Please commit against the new repository
COOK-937 - Users cookbook should allow for password hashes
Reopened - Use chef_gem, use build-essential
COOK-1011 - PostgreSQL and Apt Cookbooks Bad Interaction
Reopened - The pg gem should be installed immediately
COOK-1136 - Runit cookbook doesn’t set owner/group for the supervise directory
Reopened - What is the erroneous file in the templates folder?
COOK-1176 - OS X support for Maven
Reopened - Add backward compatibility for m2_home, drop homebrew dependency
COOK-1299 - Use App::cpanminus to install packages
Reopened - Don’t vendor cpanm in the cookbook, download it from the tubernet.


Bryan McLellan | opscode | technical program manager, open source
© 206.607.7108 | (t) @btmspox | (b) http://blog.loftninjas.org

[1] http://tickets.opscode.com/browse/CHEF-3282


#2

CHEF-3282 is awesome! Definitely would make use of that.

I gave 10.14.0 a run in one of our staging environments, and while
getting used to -W why run mode will take some time, I noticed no
obvious regressions.

Will continue testing!

–AJ

On 12 July 2012 09:22, Bryan McLellan btm@opscode.com wrote:

Hey Chefs. We’ll be tidying up Chef 10.14.0 and cutting a release
candidate soon. I haven’t heard of any regressions in 10.12.0, so let
me know if anything knocked you over please.

We’ve proposed expanding the “depends” DSL to take an optional
platform_family requirement, e.g.:

depends “windows”, "windows"
depends “apt”, “debian”

Any thoughts on that? Are we missing uses cases? You can follow up on
CHEF-3282 [1].

To merge:
CHEF-3092 - knife cookbook upload -a should batch uploads
CHEF-3178 - cron provider does not support month names and weekday names
CHEF-3254 - Run garbage collector before sleeping
CHEF-3280 - Permit chef to run solr searches with @ in terms
CHEF-3273 - Webui returning “undefined method `empty?’ for
nil:NilClass” on invalid files
COOK-811 - Windows package provider does not pass through a timeout attribute
COOK-1296 - move build-essential installation to compile-time and
platform_family-ize it
COOK-1136 - Runit cookbook doesn’t set owner/group for the supervise directory
COOK-1291 - Snapshot retention policy confusing
COOK-1298 - Re-factor NTP recipe into a reference cookbook for testing
COOK-1237 - Mysql cookbook downloads windows cookbook which causes
issues on other systems

Other:
KNIFE_EC2-67 - Add an option to bind instance to elastic ip prior to bootstrap
Reopened - Ask the mailing list
KNIFE_EC2-68 - Add a family of commands for manipulating elastic ip addresses.
Closed - Wontfix, as a policy knife-ec2 shouldn’t merely duplicate
ec2-tools functionality
KNIFE_EC2-69 - Adding ssh_gateway support for tunneling in VPCs
Reopened - Crufty commit, upfactor to knife bootstrap
CHEF-3270 - Permit chef to be run in empty env
Reopened - Add a regression test
COOK-543 - php.ini template should be configurable
Reopened - Please commit against the new repository
COOK-937 - Users cookbook should allow for password hashes
Reopened - Use chef_gem, use build-essential
COOK-1011 - PostgreSQL and Apt Cookbooks Bad Interaction
Reopened - The pg gem should be installed immediately
COOK-1136 - Runit cookbook doesn’t set owner/group for the supervise directory
Reopened - What is the erroneous file in the templates folder?
COOK-1176 - OS X support for Maven
Reopened - Add backward compatibility for m2_home, drop homebrew dependency
COOK-1299 - Use App::cpanminus to install packages
Reopened - Don’t vendor cpanm in the cookbook, download it from the tubernet.


Bryan McLellan | opscode | technical program manager, open source
© 206.607.7108 | (t) @btmspox | (b) http://blog.loftninjas.org

[1] http://tickets.opscode.com/browse/CHEF-3282


#3

Bryan,

What would the JSON look like? Will it be backward compatible?

Cheers,
Jay

On Wed, Jul 11, 2012 at 5:22 PM, Bryan McLellan btm@opscode.com wrote:

Hey Chefs. We’ll be tidying up Chef 10.14.0 and cutting a release
candidate soon. I haven’t heard of any regressions in 10.12.0, so let
me know if anything knocked you over please.

We’ve proposed expanding the “depends” DSL to take an optional
platform_family requirement, e.g.:

depends “windows”, "windows"
depends “apt”, “debian”

Any thoughts on that? Are we missing uses cases? You can follow up on
CHEF-3282 [1].

To merge:
CHEF-3092 - knife cookbook upload -a should batch uploads
CHEF-3178 - cron provider does not support month names and weekday names
CHEF-3254 - Run garbage collector before sleeping
CHEF-3280 - Permit chef to run solr searches with @ in terms
CHEF-3273 - Webui returning “undefined method `empty?’ for
nil:NilClass” on invalid files
COOK-811 - Windows package provider does not pass through a timeout
attribute
COOK-1296 - move build-essential installation to compile-time and
platform_family-ize it
COOK-1136 - Runit cookbook doesn’t set owner/group for the supervise
directory
COOK-1291 - Snapshot retention policy confusing
COOK-1298 - Re-factor NTP recipe into a reference cookbook for testing
COOK-1237 - Mysql cookbook downloads windows cookbook which causes
issues on other systems

Other:
KNIFE_EC2-67 - Add an option to bind instance to elastic ip prior to
bootstrap
Reopened - Ask the mailing list
KNIFE_EC2-68 - Add a family of commands for manipulating elastic ip
addresses.
Closed - Wontfix, as a policy knife-ec2 shouldn’t merely duplicate
ec2-tools functionality
KNIFE_EC2-69 - Adding ssh_gateway support for tunneling in VPCs
Reopened - Crufty commit, upfactor to knife bootstrap
CHEF-3270 - Permit chef to be run in empty env
Reopened - Add a regression test
COOK-543 - php.ini template should be configurable
Reopened - Please commit against the new repository
COOK-937 - Users cookbook should allow for password hashes
Reopened - Use chef_gem, use build-essential
COOK-1011 - PostgreSQL and Apt Cookbooks Bad Interaction
Reopened - The pg gem should be installed immediately
COOK-1136 - Runit cookbook doesn’t set owner/group for the supervise
directory
Reopened - What is the erroneous file in the templates folder?
COOK-1176 - OS X support for Maven
Reopened - Add backward compatibility for m2_home, drop homebrew
dependency
COOK-1299 - Use App::cpanminus to install packages
Reopened - Don’t vendor cpanm in the cookbook, download it from the
tubernet.


Bryan McLellan | opscode | technical program manager, open source
© 206.607.7108 | (t) @btmspox | (b) http://blog.loftninjas.org

[1] http://tickets.opscode.com/browse/CHEF-3282


#4

On Wed, Jul 11, 2012 at 11:25 PM, AJ Christensen aj@junglist.gen.nz wrote:

CHEF-3282 is awesome! Definitely would make use of that.

+1

I still pin the subversion cookbook to 0.8.3 because of COOK-1142* for
example and the less clutter in librarian’s Cheffile the better.

Regards,
Mike

I gave 10.14.0 a run in one of our staging environments, and while
getting used to -W why run mode will take some time, I noticed no
obvious regressions.

Will continue testing!

–AJ

On 12 July 2012 09:22, Bryan McLellan btm@opscode.com wrote:

Hey Chefs. We’ll be tidying up Chef 10.14.0 and cutting a release
candidate soon. I haven’t heard of any regressions in 10.12.0, so let
me know if anything knocked you over please.

We’ve proposed expanding the “depends” DSL to take an optional
platform_family requirement, e.g.:

depends “windows”, "windows"
depends “apt”, “debian”

Any thoughts on that? Are we missing uses cases? You can follow up on
CHEF-3282 [1].

To merge:
CHEF-3092 - knife cookbook upload -a should batch uploads
CHEF-3178 - cron provider does not support month names and weekday names
CHEF-3254 - Run garbage collector before sleeping
CHEF-3280 - Permit chef to run solr searches with @ in terms
CHEF-3273 - Webui returning “undefined method `empty?’ for
nil:NilClass” on invalid files
COOK-811 - Windows package provider does not pass through a timeout attribute
COOK-1296 - move build-essential installation to compile-time and
platform_family-ize it
COOK-1136 - Runit cookbook doesn’t set owner/group for the supervise directory
COOK-1291 - Snapshot retention policy confusing
COOK-1298 - Re-factor NTP recipe into a reference cookbook for testing
COOK-1237 - Mysql cookbook downloads windows cookbook which causes
issues on other systems

Other:
KNIFE_EC2-67 - Add an option to bind instance to elastic ip prior to bootstrap
Reopened - Ask the mailing list
KNIFE_EC2-68 - Add a family of commands for manipulating elastic ip addresses.
Closed - Wontfix, as a policy knife-ec2 shouldn’t merely duplicate
ec2-tools functionality
KNIFE_EC2-69 - Adding ssh_gateway support for tunneling in VPCs
Reopened - Crufty commit, upfactor to knife bootstrap
CHEF-3270 - Permit chef to be run in empty env
Reopened - Add a regression test
COOK-543 - php.ini template should be configurable
Reopened - Please commit against the new repository
COOK-937 - Users cookbook should allow for password hashes
Reopened - Use chef_gem, use build-essential
COOK-1011 - PostgreSQL and Apt Cookbooks Bad Interaction
Reopened - The pg gem should be installed immediately
COOK-1136 - Runit cookbook doesn’t set owner/group for the supervise directory
Reopened - What is the erroneous file in the templates folder?
COOK-1176 - OS X support for Maven
Reopened - Add backward compatibility for m2_home, drop homebrew dependency
COOK-1299 - Use App::cpanminus to install packages
Reopened - Don’t vendor cpanm in the cookbook, download it from the tubernet.


Bryan McLellan | opscode | technical program manager, open source
© 206.607.7108 | (t) @btmspox | (b) http://blog.loftninjas.org

[1] http://tickets.opscode.com/browse/CHEF-3282


Mike Adolphs
Stitenstrasse 24
23554 Luebeck

  • Germany -

Mail. mike@fooforge.com
Web. http://fooforge.com/
Github. https://github.com/fooforge/
XING. http://www.xing.com/profile/Mike_Adolphs