A few Chef Software folks in attendance today. We reviewed some pull
requests that had been labeled “Needs Review” in the Chef repository.
Chef PR #1561: Add environment resource attributer to scm resources
Reviewed - Keep the same pattern for run_opts[:environment]
Chef PR #1576: Retry on ssh failure in knife/ssh.rb
Reviewed - Add a debug message, make it configurable.
Chef PR #1577: Always check for expanded path of secret file
Reviewed - Don’t use the sideaffect of nil.to_s to avoid raising an exception
Chef PR #1266: [CHEF-5035] Allow relative symlinks on Windows
Reviewed - Don’t break existing/prevent absolute path based symlinks
Bryan McLellan | chef | software engineer
© 206.607.7108 | (t) @btmspox | (www) http://getchef.com