8/23 Opscode Code Review


#1

Merge:
COOK-2925 - chefspec coverage for nginx::default and nginx_site definitions

Other:
COOK-1863 - Install chef-client as a Windows Service
Reopened - Use Gem::Requirement
COOK-1170 - Cannot redefine NTP servers in role.rb
Reopened - Please fix up the array formatting please
COOK-3273 - Add tests to NTP cookbook
Reopened - test improvements
COOK-3332 - nagios::client fails under chef-solo
Reopened - Check out chef-zero + test-kitchen
COOK-3390 - Create directory /etc/mysql before do template "#{node[‘mysql’][‘conf_dir’]}/debian.cnf"
Reopened - Move the template down below where the directories are created.


Bryan McLellan | opscode | technical program manager, open source
© 206.607.7108 | (t) @btmspox | (b) http://blog.loftninjas.org


#2

On Aug 23, 2013, at 4:35 PM, Bryan McLellan btm@opscode.com wrote:

COOK-1170 - Cannot redefine NTP servers in role.rb
Reopened - Please fix up the array formatting please
COOK-3273 - Add tests to NTP cookbook
Reopened - test improvements

What about COOK-2795? Can I at least get some feedback on it?


Brad Knowles brad@shub-internet.org
LinkedIn Profile: http://tinyurl.com/y8kpxu


#3

On Aug 23, 2013, at 6:08 PM, Brad Knowles brad@shub-internet.org wrote:

On Aug 23, 2013, at 4:35 PM, Bryan McLellan btm@opscode.com wrote:

COOK-1170 - Cannot redefine NTP servers in role.rb
Reopened - Please fix up the array formatting please
COOK-3273 - Add tests to NTP cookbook
Reopened - test improvements

What about COOK-2795? Can I at least get some feedback on it?

Brad,

It’s not marked as “Fix Provided” in JIRA so it didn’t get picked up in review. If you change the status, it’ll show up in the next code review filter.

  • Julian

#4

On Aug 23, 2013, at 9:32 PM, Julian C. Dunn jdunn@aquezada.com wrote:

It’s not marked as “Fix Provided” in JIRA so it didn’t get picked up in review. If you change the status, it’ll show up in the next code review filter.

Ahh. I wasn’t aware that was a requirement to get pull requests reviewed. I’ll fix that now.

Thanks!


Brad Knowles brad@shub-internet.org
LinkedIn Profile: http://tinyurl.com/y8kpxu


#5

Hate to do this, but maybe everyone else can benefit:

This is from the Chef repo, and it’s pretty much the same on most
Opscode-maintained cookbooks. Lots of details on how to contribute back.

-M

On Fri, Aug 23, 2013 at 8:33 PM, Brad Knowles brad@shub-internet.orgwrote:

On Aug 23, 2013, at 9:32 PM, Julian C. Dunn jdunn@aquezada.com wrote:

It’s not marked as “Fix Provided” in JIRA so it didn’t get picked up in
review. If you change the status, it’ll show up in the next code review
filter.

Ahh. I wasn’t aware that was a requirement to get pull requests reviewed.
I’ll fix that now.

Thanks!


Brad Knowles brad@shub-internet.org
LinkedIn Profile: http://tinyurl.com/y8kpxu


#6

On Aug 23, 2013, at 10:45 PM, Mike miketheman@gmail.com wrote:

Hate to do this, but maybe everyone else can benefit:

This is from the Chef repo, and it’s pretty much the same on most Opscode-maintained cookbooks. Lots of details on how to contribute back.
https://github.com/opscode/chef/blob/master/CONTRIBUTING.md#code-review

That’s a good pointer. I signed the CLA a while back, and my current employer signed the CCLA back when I was hired, but I must confess that I haven’t reviewed the details of the contribution process since I signed.

Thanks!


Brad Knowles brad@shub-internet.org
LinkedIn Profile: http://tinyurl.com/y8kpxu