Any ETA on partial search?


#1

If any of you have used chef-rundeck in a non-trivial chef environment, you know that it’s painfully slow. So I’ve put together a patch to use the Chef::PartialSearch from the partial_search cookbook. I get ~10x speedup, and this is just a spike.

But I’m not really a fan of highjacking code from a cookbook. I’ll probably be adding mockist tests to ensure that we’re making the right Chef::REST calls. Anyone making progress on COOK-2584 and CHEF-3878? Anything I can do to help get this out the door?

~j


#2

On Monday, October 14, 2013 at 9:03 PM, Joseph Holsten wrote:

If any of you have used chef-rundeck in a non-trivial chef environment, you know that it’s painfully slow. So I’ve put together a patch to use the Chef::PartialSearch from the partial_search cookbook. I get ~10x speedup, and this is just a spike.

https://github.com/oswaldlabs/chef-rundeck/pull/34

But I’m not really a fan of highjacking code from a cookbook. I’ll probably be adding mockist tests to ensure that we’re making the right Chef::REST calls. Anyone making progress on COOK-2584 and CHEF-3878? Anything I can do to help get this out the door?

~j

Same stuff I said here: https://tickets.opscode.com/browse/CHEF-3878?focusedCommentId=32885&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-32885

  1. Add tests (this is the most important part)
  2. Define the #partial_search DSL method on Chef::DSL::DataQuery instead of implicitly defining it on Object.
  3. Break up some of the long methods in the code to do only one thing at a time so it’s easier to read and test.

#1 is required, #2 and #3 are simple enough that I could do them in a few minutes if you’re unsure about it.


Daniel DeLeo