Bryan, I made all of those changes - good suggestions. I rebased my
commits, added the ticket number to the commit message, and updated my JIRA
ticket to include testing information and a link to the release notes for
It’s been over a week since my initial pull request. Is there something I
should bump to get someone to take a look?
On Thu, Oct 24, 2013 at 9:21 AM, Bryan McLellan firstname.lastname@example.org wrote:
That’s it Chris, thanks!
The basic steps are here:
Cookbook Code Review happens Monday, Wednesday and Friday, as
documented on the Code Review link that Kannan pointed out.
I see you’ve got a commit on your pull request to fix up an change.
It’s worth looking into using “git rebase -i” to merge that commit
back into a single commit, and add the ticket number to the commit
message. That helps other contributors down the road find more
information about what a certain change was made by easily being able
to find the ticket.
It’s good when you bump a version to explicitly mention on the ticket
that you’ve tested this version on such and such platform, and the
reason the new version is important is because of foo security fix or
bar awesome feature.