Anything other than CLA and pull request to get changes merged?


#1

I upgraded the java cookbook to install the latest release of Java, opened
a pull request https://github.com/opscode-cookbooks/java/pull/88, and opened
a ticket https://tickets.opscode.com/browse/COOK-3823 in Opscode JIRA. Is
there anything else I need to do for it to be considered in the next code
review? How often do code reviews occur for cookbook changes?

Thanks,
Chris


#2

Hey Chris,

In my experience, the fastest way to get something like this looked at is
to attend the next code review and ask them to take a look at it. I don’t
remember the exact schedule for COOK code reviews, but I believe it is
twice a week. Someone in #chef on freenode can tell you.

On Thu, Oct 24, 2013 at 3:47 AM, Christopher Armstrong <
chris@chrisarmstrong.me> wrote:

I upgraded the java cookbook to install the latest release of Java, opened
a pull request https://github.com/opscode-cookbooks/java/pull/88, and opened
a ticket https://tickets.opscode.com/browse/COOK-3823 in Opscode JIRA.
Is there anything else I need to do for it to be considered in the next
code review? How often do code reviews occur for cookbook changes?

Thanks,
Chris


#3

The schedule for code reviews can be found here:
https://wiki.opscode.com/display/chef/Code+Review

On Thu, Oct 24, 2013 at 7:50 AM, Andrew Gross andrew@yipit.com wrote:

Hey Chris,

In my experience, the fastest way to get something like this looked at is
to attend the next code review and ask them to take a look at it. I don’t
remember the exact schedule for COOK code reviews, but I believe it is
twice a week. Someone in #chef on freenode can tell you.

On Thu, Oct 24, 2013 at 3:47 AM, Christopher Armstrong <
chris@chrisarmstrong.me> wrote:

I upgraded the java cookbook to install the latest release of Java, opened
a pull request https://github.com/opscode-cookbooks/java/pull/88, and opened
a ticket https://tickets.opscode.com/browse/COOK-3823 in Opscode JIRA.
Is there anything else I need to do for it to be considered in the next
code review? How often do code reviews occur for cookbook changes?

Thanks,
Chris


#4

That’s it Chris, thanks!

The basic steps are here: http://docs.opscode.com/community_contributions.html

Cookbook Code Review happens Monday, Wednesday and Friday, as
documented on the Code Review link that Kannan pointed out.

I see you’ve got a commit on your pull request to fix up an change.
It’s worth looking into using “git rebase -i” to merge that commit
back into a single commit, and add the ticket number to the commit
message. That helps other contributors down the road find more
information about what a certain change was made by easily being able
to find the ticket.

It’s good when you bump a version to explicitly mention on the ticket
that you’ve tested this version on such and such platform, and the
reason the new version is important is because of foo security fix or
bar awesome feature.

Bryan


#5

Thanks guys!

Bryan, I made all of those changes - good suggestions. I rebased my
commits, added the ticket number to the commit message, and updated my JIRA
ticket to include testing information and a link to the release notes for
7u45.

It’s been over a week since my initial pull request. Is there something I
should bump to get someone to take a look?

On Thu, Oct 24, 2013 at 9:21 AM, Bryan McLellan btm@loftninjas.org wrote:

That’s it Chris, thanks!

The basic steps are here:
http://docs.opscode.com/community_contributions.html

Cookbook Code Review happens Monday, Wednesday and Friday, as
documented on the Code Review link that Kannan pointed out.

I see you’ve got a commit on your pull request to fix up an change.
It’s worth looking into using “git rebase -i” to merge that commit
back into a single commit, and add the ticket number to the commit
message. That helps other contributors down the road find more
information about what a certain change was made by easily being able
to find the ticket.

It’s good when you bump a version to explicitly mention on the ticket
that you’ve tested this version on such and such platform, and the
reason the new version is important is because of foo security fix or
bar awesome feature.

Bryan


#6

On Fri, Oct 25, 2013 at 8:05 AM, Christopher Armstrong
chris@chrisarmstrong.me wrote:

It’s been over a week since my initial pull request. Is there something I
should bump to get someone to take a look?

No. The regular process will get to it, there’s just a bit of a
backlog for COOK tickets for review again.

https://tickets.opscode.com/secure/IssueNavigator.jspa?mode=hide&requestId=10970

We’re always looking for folks in the community to help go through
these tickets outside of review and comment on other peoples pull
requests for things like documentation, tests (if appropriate), code
quality, better solutions, and also that you tested it out and it
worked good for you.


Bryan McLellan | opscode | technical program manager, open source
© 206.607.7108 | (t) @btmspox | (b) http://blog.loftninjas.org


#7

Sounds good. I’ll see if I can help.

On Fri, Oct 25, 2013 at 6:56 AM, Bryan McLellan btm@opscode.com wrote:

On Fri, Oct 25, 2013 at 8:05 AM, Christopher Armstrong
chris@chrisarmstrong.me wrote:

It’s been over a week since my initial pull request. Is there something I
should bump to get someone to take a look?

No. The regular process will get to it, there’s just a bit of a
backlog for COOK tickets for review again.

https://tickets.opscode.com/secure/IssueNavigator.jspa?mode=hide&requestId=10970

We’re always looking for folks in the community to help go through
these tickets outside of review and comment on other peoples pull
requests for things like documentation, tests (if appropriate), code
quality, better solutions, and also that you tested it out and it
worked good for you.


Bryan McLellan | opscode | technical program manager, open source
© 206.607.7108 | (t) @btmspox | (b) http://blog.loftninjas.org