CHEF Code Review 30 Sept 2013


#1

Hi Chefs,

Here’s what we looked at during yesterday’s Chef/Ohai code review:

To Merge:

  • CHEF-4235 This patch is good, the chef-server team will make sure it’s tested before merging.
  • CHEF-4084 Simple enough
  • CHEF-4465 Tests are fixed, this is good to go.

Reopened:

  • CHEF-3219 Needs a test, there might be a better place to put this logic.

Other:

  • CHEF-3838 The server team has been doing some parallel work to pull in cookbooks such as runit from upstream. They’ll keep an eye on this and merge any patches that still apply once they’re done.
  • CHEF-4572 Doc bug that’s been fixed.


Daniel DeLeo