How to test Chef::REST.run_request

Jeppe_Nejsum_Madsen · 2009-07-13 10:57:49 UTC

In order to write a test for CHEF-269, I need to write a test for
Chef::REST.run_request. Unfortunately, this code is prefixed with

   # TODO - Figure out how to test this block - I really have no

idea how
# to do it without actually calling http.request…

So, what is the best way to approach this?

/Jeppe

Arjuna_Christensen · 2009-07-13 11:00:30 UTC

On 13/07/2009, at 10:57 PM, Jeppe Nejsum Madsen wrote:

In order to write a test for CHEF-269, I need to write a test for
Chef::REST.run_request. Unfortunately, this code is prefixed with
 # TODO - Figure out how to test this block - I really have no  
idea how
# to do it without actually calling http.request…

So, what is the best way to approach this?

Looks to be a legacy TODO - there are functioning tests for
#run_request:

github.com

chef/chef/blob/94b6530e69f3f50dcce11990a922ec7a5bd02706/chef/spec/unit/rest_spec.rb

#
# Author:: Adam Jacob (<adam@opscode.com>)
# Copyright:: Copyright (c) 2008 Opscode, Inc.
# License:: Apache License, Version 2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
# 
#     http://www.apache.org/licenses/LICENSE-2.0
# 
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#

require File.expand_path(File.join(File.dirname(__FILE__), "..", "spec_helper"))
require 'uri'

This file has been truncated. show original

Regards,

–
AJ Christensen, Software Engineer
Opscode, Inc.
E: aj@opscode.com

Jeppe_Nejsum_Madsen · 2009-07-13 11:47:06 UTC

On 13/07/2009, at 13.00, Arjuna Christensen wrote:

On 13/07/2009, at 10:57 PM, Jeppe Nejsum Madsen wrote:
In order to write a test for CHEF-269, I need to write a test for
Chef::REST.run_request. Unfortunately, this code is prefixed with
 # TODO - Figure out how to test this block - I really have no  
idea how
# to do it without actually calling http.request…

So, what is the best way to approach this?
Looks to be a legacy TODO - there are functioning tests for
#run_request:

http://github.com/opscode/chef/blob/94b6530e69f3f50dcce11990a922ec7a5bd02706/chef/spec/unit/rest_spec.rb#L93

Ahh thanks. So, I actually succeeded in creating a fix, complete with
spec and everything (not bad for a Java/Scala guy, eh :-).

If somebody want to do a sanity check: http://github.com/jeppenejsum/chef/tree/CHEF-269

/Jeppe