Ohai key name


#1

There’s a proposal to change [:virtualization][:emulator] to
[:virtualization][:system] for the Linux virtualization plugin (and
probably the new Solaris plugin that is based on it) in ohai to match
up with the BSD plugin.

Now would be the time to do it, as it is a breaking change for some
people, because we’re getting ready to release ohai 0.6.0 with chef
0.10.0.

What opinions does everyone have on what it should be, and if it
should be changed?

http://tickets.opscode.com/browse/OHAI-222

Bryan


#2

+1 for standardizing this. If we are worried about not breakign anyone you could also just ensure the value is available under both the ‘emulator’ and ‘system’ keys. This could be done fairly easily in the top level virtualization plugin:

Seth


Opscode, Inc.
Seth Chisamore, Technical Evangelist
IRC, Skype, Twitter, Github: schisamo

On Wednesday, April 6, 2011 at 3:12 PM, Bryan McLellan wrote:
There’s a proposal to change [:virtualization][:emulator] to

[:virtualization][:system] for the Linux virtualization plugin (and
probably the new Solaris plugin that is based on it) in ohai to match
up with the BSD plugin.

Now would be the time to do it, as it is a breaking change for some
people, because we’re getting ready to release ohai 0.6.0 with chef
0.10.0.

What opinions does everyone have on what it should be, and if it
should be changed?

http://tickets.opscode.com/browse/OHAI-222

Bryan


#3

]] Seth Chisamore

| +1 for standardizing this. If we are worried about not breakign anyone
| you could also just ensure the value is available under both the
| ‘emulator’ and ‘system’ keys. This could be done fairly easily in the
| top level virtualization plugin:

Slightly related, at least for ohai plugins shipped with ohai itself,
it’d be useful to have a ohai/api_version or somesuch that would be
bumped if keys are changed in backwards-incompatible fashions, and
recipes could just have a list of known good ohai versions.


Tollef Fog Heen
UNIX is user friendly, it’s just picky about who its friends are


#4

On Wed, Apr 6, 2011 at 12:40 PM, Seth Chisamore schisamo@opscode.com wrote:

+1 for standardizing this. If we are worried about not breakign anyone you could also just ensure the value is available under both the ‘emulator’ and ‘system’ keys. This could be done fairly easily in the top level virtualization plugin:
https://github.com/opscode/ohai/blob/master/lib/ohai/plugins/virtualization.rb

Yeah, but I think you’d want to use an API version mechanism such as
Tollef suggests so you can still deprecate the keys, otherwise you end
up with everyone paying to cost of storing the data twice.

Thus far we’ve stated that there may be breaking changes on major
releases, so I think it is a safe time to do this. Mostly I was
wondering if anyone felt strongly for or against, otherwise I just
think it’s a reasonable thing to do.

Bryan


#5

On Wed, Apr 6, 2011 at 21:40, Bryan McLellan btm@loftninjas.org wrote:

Thus far we’ve stated that there may be breaking changes on major
releases, so I think it is a safe time to do this. Mostly I was
wondering if anyone felt strongly for or against, otherwise I just
think it’s a reasonable thing to do.

I agree that this is an entirely reasonable thing to do, and -
personally - I don’t see a
need for deprecation before we reach 1.0 .
Cheers,
-Thom