Question about the application cookbook


#1

So I’m converting my hand rolled deployment resource to use the application cookbook, and I’ve got a question about it. Or rather I’d like to point out that the rails and unicorn recipes are inconsistent in how they deal with attributes.

The rails recipe does this:

node[:apps][app[‘id’]][node.app_environment][:run_migrations]

The unicorn one on the other hand does

node.default[:unicorn][:worker_timeout] = 60
node.default[:unicorn][:preload_app] = false
node.default[:unicorn][:worker_processes] = [node[:cpu][:total].to_i * 4, 8].min

Now the unicorn config is node global and doesn’t let you tweak things based on the app. Should it?

node.default[:apps][app[‘id’]][:unicorn][:worker_timeout] = 60

Thoughts?

-ash


#2

On 8 Sep 2010, at 20:58, Ash Berlin wrote:

So I’m converting my hand rolled deployment resource to use the application cookbook, and I’ve got a question about it. Or rather I’d like to point out that the rails and unicorn recipes are inconsistent in how they deal with attributes.

The rails recipe does this:

node[:apps][app[‘id’]][node.app_environment][:run_migrations]

The unicorn one on the other hand does

node.default[:unicorn][:worker_timeout] = 60
node.default[:unicorn][:preload_app] = false
node.default[:unicorn][:worker_processes] = [node[:cpu][:total].to_i * 4, 8].min

Now the unicorn config is node global and doesn’t let you tweak things based on the app. Should it?

node.default[:apps][app[‘id’]][:unicorn][:worker_timeout] = 60

This should be

node[:apps][app[‘id’]][node.app_environment][:unicorn][:worker_timeout]

to be properly consistent.

Thoughts?

-ash