11.6.0 and sudo issue

Morgan_Blackthorne · July 26, 2013, 12:25am

I just tried bumping my nodes to 11.6.0 and got this error from a recipe
using the sudo LWRP. Any thoughts?

https://gist.github.com/stormerider/6085044

I just wrote that today, but it did work before I bumped the clients to
11.6.0 from 11.4.4. And I’m not seeing any changes in the cookbook that
seem to apply to this.

–
~~ StormeRider ~~

“Every world needs its heroes […] They inspire us to be better than we
are. And they protect from the darkness that’s just around the corner.”

(from Smallville Season 6x1: “Zod”)

On why I hate the phrase “that’s so lame”… http://bit.ly/Ps3uSS

Steven_Danna · July 26, 2013, 1:38am

On 7/25/13 5:25 PM, Morgan Blackthorne wrote:

I just tried bumping my nodes to 11.6.0 and got this error from a recipe
using the sudo LWRP. Any thoughts?

https://gist.github.com/stormerider/6085044

I just wrote that today, but it did work before I bumped the clients to
11.6.0 from 11.4.4. And I'm not seeing any changes in the cookbook that
seem to apply to this.

One of our developers found this issue today and has submitted a fix for
the sudo cookbook here:

https://github.com/opscode-cookbooks/sudo/pull/29

The sudo lwrp manipulates the template in a bit of a non-standard way:

https://github.com/opscode-cookbooks/sudo/blob/master/providers/default.rb#L122-L123

which was broken by some changes to how templates are handled internally:

https://github.com/opscode/chef/commit/ca4cd1f830fae2fac3e2c18bbd2693b0caddcb33

--
~~ StormeRider ~~

"Every world needs its heroes [...] They inspire us to be better than we
are. And they protect from the darkness that's just around the corner."

(from Smallville Season 6x1: "Zod")

On why I hate the phrase "that's so lame"... http://bit.ly/Ps3uSS

--
Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key

Morgan_Blackthorne · July 26, 2013, 1:41am

Aha, thanks!

–
~~ StormeRider ~~

“Every world needs its heroes […] They inspire us to be better than we
are. And they protect from the darkness that’s just around the corner.”

(from Smallville Season 6x1: “Zod”)

On why I hate the phrase “that’s so lame”… http://bit.ly/Ps3uSS

On Thu, Jul 25, 2013 at 6:38 PM, Steven Danna steve@opscode.com wrote:

On 7/25/13 5:25 PM, Morgan Blackthorne wrote:

I just tried bumping my nodes to 11.6.0 and got this error from a recipe
using the sudo LWRP. Any thoughts?

https://gist.github.com/stormerider/6085044

I just wrote that today, but it did work before I bumped the clients to
11.6.0 from 11.4.4. And I’m not seeing any changes in the cookbook that
seem to apply to this.

One of our developers found this issue today and has submitted a fix for
the sudo cookbook here:
https://github.com/opscode-cookbooks/sudo/pull/29
The sudo lwrp manipulates the template in a bit of a non-standard way:

https://github.com/opscode-cookbooks/sudo/blob/master/providers/default.rb#L122-L123

which was broken by some changes to how templates are handled internally:

https://github.com/opscode/chef/commit/ca4cd1f830fae2fac3e2c18bbd2693b0caddcb33

–
~~ StormeRider ~~

“Every world needs its heroes […] They inspire us to be better than we
are. And they protect from the darkness that’s just around the corner.”

(from Smallville Season 6x1: “Zod”)

On why I hate the phrase “that’s so lame”… http://bit.ly/Ps3uSS

–
Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key

Tim_Smith1 · July 26, 2013, 1:56am

Steven,

Do all uses of node[‘fqdn’] need to be converted to @node[‘fqdn’] in erbs going forward?

-Tim

On Jul 25, 2013, at 6:38 PM, Steven Danna steve@opscode.com wrote:

On 7/25/13 5:25 PM, Morgan Blackthorne wrote:
I just tried bumping my nodes to 11.6.0 and got this error from a recipe
using the sudo LWRP. Any thoughts?

https://gist.github.com/stormerider/6085044

I just wrote that today, but it did work before I bumped the clients to
11.6.0 from 11.4.4. And I’m not seeing any changes in the cookbook that
seem to apply to this.

One of our developers found this issue today and has submitted a fix for
the sudo cookbook here:

https://github.com/opscode-cookbooks/sudo/pull/29

The sudo lwrp manipulates the template in a bit of a non-standard way:

https://github.com/opscode-cookbooks/sudo/blob/master/providers/default.rb#L122-L123

which was broken by some changes to how templates are handled internally:

https://github.com/opscode/chef/commit/ca4cd1f830fae2fac3e2c18bbd2693b0caddcb33

–
~~ StormeRider ~~

“Every world needs its heroes […] They inspire us to be better than we
are. And they protect from the darkness that’s just around the corner.”

(from Smallville Season 6x1: “Zod”)

On why I hate the phrase “that’s so lame”… http://bit.ly/Ps3uSS

–
Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key

Steven_Danna · July 26, 2013, 2:42am

On 7/25/13 6:56 PM, Tim Smith wrote:

Steven,

Do all uses of node[‘fqdn’] need to be converted to @node[‘fqdn’] in erbs going forward?

No. The only cookbooks that would need to change are those that directly
use Erubis::Eruby like the sudo cookbook does:

github.com

chef-cookbooks/sudo/blob/master/providers/default.rb

#
# Author:: Bryan W. Berry (<bryan.berry@gmail.com>)
# Author:: Seth Vargo (<sethvargo@gmail.com>)
# Cookbook:: sudo
# Provider:: default
#
# Copyright:: 2011-2016, Bryan w. Berry
# Copyright:: 2012-2016, Seth Vargo
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

This file has been truncated. show original

We confirmed that the sudo cookbook is the only Opscode maintained
cookbook using this pattern.

Cheers,

Steven

-Tim

On Jul 25, 2013, at 6:38 PM, Steven Danna steve@opscode.com wrote:

On 7/25/13 5:25 PM, Morgan Blackthorne wrote:
I just tried bumping my nodes to 11.6.0 and got this error from a recipe
using the sudo LWRP. Any thoughts?

https://gist.github.com/stormerider/6085044

I just wrote that today, but it did work before I bumped the clients to
11.6.0 from 11.4.4. And I’m not seeing any changes in the cookbook that
seem to apply to this.

One of our developers found this issue today and has submitted a fix for
the sudo cookbook here:

https://github.com/opscode-cookbooks/sudo/pull/29

The sudo lwrp manipulates the template in a bit of a non-standard way:

https://github.com/opscode-cookbooks/sudo/blob/master/providers/default.rb#L122-L123

which was broken by some changes to how templates are handled internally:

https://github.com/opscode/chef/commit/ca4cd1f830fae2fac3e2c18bbd2693b0caddcb33

–
~~ StormeRider ~~

“Every world needs its heroes […] They inspire us to be better than we
are. And they protect from the darkness that’s just around the corner.”

(from Smallville Season 6x1: “Zod”)

On why I hate the phrase “that’s so lame”… http://bit.ly/Ps3uSS

–
Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key

–
Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key

Joshua_Timberman · July 26, 2013, 3:10am

I pushed an alternative branch that removes the node attribute use in those templates entirely. Also, doesn't appear that the template for the recipe needs @node.

Joshua

On Thursday, July 25, 2013 at 19:42, Steven Danna wrote:

On 7/25/13 6:56 PM, Tim Smith wrote:

Steven,

Do all uses of node['fqdn'] need to be converted to @node['fqdn'] in erbs going forward?

No. The only cookbooks that would need to change are those that directly
use Erubis::Eruby like the sudo cookbook does:

https://github.com/opscode-cookbooks/sudo/blob/master/providers/default.rb#L122

We confirmed that the sudo cookbook is the only Opscode maintained
cookbook using this pattern.

Cheers,

Steven

-Tim

On Jul 25, 2013, at 6:38 PM, Steven Danna steve@opscode.com wrote:

On 7/25/13 5:25 PM, Morgan Blackthorne wrote:
I just tried bumping my nodes to 11.6.0 and got this error from a recipe
using the sudo LWRP. Any thoughts?

https://gist.github.com/stormerider/6085044

I just wrote that today, but it did work before I bumped the clients to
11.6.0 from 11.4.4. And I'm not seeing any changes in the cookbook that
seem to apply to this.

One of our developers found this issue today and has submitted a fix for
the sudo cookbook here:

https://github.com/opscode-cookbooks/sudo/pull/29

The sudo lwrp manipulates the template in a bit of a non-standard way:

https://github.com/opscode-cookbooks/sudo/blob/master/providers/default.rb#L122-L123

which was broken by some changes to how templates are handled internally:

https://github.com/opscode/chef/commit/ca4cd1f830fae2fac3e2c18bbd2693b0caddcb33

--
~~ StormeRider ~~

"Every world needs its heroes [...] They inspire us to be better than we
are. And they protect from the darkness that's just around the corner."

(from Smallville Season 6x1: "Zod")

On why I hate the phrase "that's so lame"... http://bit.ly/Ps3uSS

--
Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key

--
Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key

Joshua_Timberman · July 26, 2013, 11:03pm

Version 2.1.4 was released earlier today to resolve this. COOK-3399.

Cheers,
Joshua

On Thursday, July 25, 2013 at 20:10, Joshua Timberman wrote:

I pushed an alternative branch that removes the node attribute use in those templates entirely. Also, doesn’t appear that the template for the recipe needs @node.

https://github.com/opscode-cookbooks/sudo/commit/6565c809111740191b1a6d170d39b61b18c04c9c

Joshua

On Thursday, July 25, 2013 at 19:42, Steven Danna wrote:

On 7/25/13 6:56 PM, Tim Smith wrote:

Steven,

Do all uses of node[‘fqdn’] need to be converted to @node[‘fqdn’] in erbs going forward?

No. The only cookbooks that would need to change are those that directly
use Erubis::Eruby like the sudo cookbook does:

https://github.com/opscode-cookbooks/sudo/blob/master/providers/default.rb#L122

We confirmed that the sudo cookbook is the only Opscode maintained
cookbook using this pattern.

Cheers,

Steven

-Tim

On Jul 25, 2013, at 6:38 PM, Steven Danna steve@opscode.com wrote:

On 7/25/13 5:25 PM, Morgan Blackthorne wrote:
I just tried bumping my nodes to 11.6.0 and got this error from a recipe
using the sudo LWRP. Any thoughts?

https://gist.github.com/stormerider/6085044

I just wrote that today, but it did work before I bumped the clients to
11.6.0 from 11.4.4. And I’m not seeing any changes in the cookbook that
seem to apply to this.

One of our developers found this issue today and has submitted a fix for
the sudo cookbook here:

https://github.com/opscode-cookbooks/sudo/pull/29

The sudo lwrp manipulates the template in a bit of a non-standard way:

https://github.com/opscode-cookbooks/sudo/blob/master/providers/default.rb#L122-L123

which was broken by some changes to how templates are handled internally:

https://github.com/opscode/chef/commit/ca4cd1f830fae2fac3e2c18bbd2693b0caddcb33

–
~~ StormeRider ~~

“Every world needs its heroes […] They inspire us to be better than we
are. And they protect from the darkness that’s just around the corner.”

(from Smallville Season 6x1: “Zod”)

On why I hate the phrase “that’s so lame”… http://bit.ly/Ps3uSS

–
Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key

–
Steven Danna
Systems Engineer, Opscode, Inc
GPG Key: http://stevendanna.github.com/downloads/code/public.key