WebUI doesn't show recipes "fully expanded"


#1

In the 0.10 WebUI when viewing a node, if you click on the Recipes
link you get an expansion labelled “This is the list of recipes, fully
expanded, as they will be applied to the node in question.”. However,
when my run list only has roles in it, all I see in the Recipes
expansion is the list of roles again…from the "fully expanded"
wording I would have expected a list of the recipes my roles refer to.
Is this a bug or what does “fully expanded” recipes mean in this
context?

Thank you in advance.

-J


#2

Yep, I reported this one a while back. I should probably make some
time to try my hand at a full patch, but the relevant code section is
pretty clear. Would be curious to confirm that this was an
implementation mistake and not an intentional choice.

http://tickets.opscode.com/browse/CHEF-2312

KC

On Wed, May 18, 2011 at 6:01 PM, Jason J. W. Williams
jasonjwwilliams@gmail.com wrote:

In the 0.10 WebUI when viewing a node, if you click on the Recipes
link you get an expansion labelled “This is the list of recipes, fully
expanded, as they will be applied to the node in question.”. However,
when my run list only has roles in it, all I see in the Recipes
expansion is the list of roles again…from the "fully expanded"
wording I would have expected a list of the recipes my roles refer to.
Is this a bug or what does “fully expanded” recipes mean in this
context?

Thank you in advance.

-J


#3

On Wednesday, May 18, 2011 at 7:30 PM, KC Braunschweig wrote:
Yep, I reported this one a while back. I should probably make some

time to try my hand at a full patch, but the relevant code section is
pretty clear. Would be curious to confirm that this was an
implementation mistake and not an intentional choice.

As I recall, the historical behavior has been that node run lists are not expanded, but role run lists are expanded. So I think the change is that the copy talking about the run list being expanded has leaked to the nodes view. Some archaeology in git would confirm/deny.


Dan DeLeo
http://tickets.opscode.com/browse/CHEF-2312

KC

On Wed, May 18, 2011 at 6:01 PM, Jason J. W. Williams
jasonjwwilliams@gmail.com wrote:

In the 0.10 WebUI when viewing a node, if you click on the Recipes
link you get an expansion labelled “This is the list of recipes, fully
expanded, as they will be applied to the node in question.”. However,
when my run list only has roles in it, all I see in the Recipes
expansion is the list of roles again…from the "fully expanded"
wording I would have expected a list of the recipes my roles refer to.
Is this a bug or what does “fully expanded” recipes mean in this
context?

Thank you in advance.

-J


#4

Well I made a change that seems to work in that my 0.10.0 chef server
now shows the expanded run list like the text says. I guess it could
be an open question if this is actually the desired behavior but it
seems better to me. Change is on my github repo
(https://github.com/kcbraunschweig/chef) in the CHEF-2312 branch. I’d
appreciate it if someone could give it a shot for testing purposes.

KC

On Wed, May 18, 2011 at 7:43 PM, Daniel DeLeo dan@kallistec.com wrote:

On Wednesday, May 18, 2011 at 7:30 PM, KC Braunschweig wrote:
Yep, I reported this one a while back. I should probably make some

time to try my hand at a full patch, but the relevant code section is
pretty clear. Would be curious to confirm that this was an
implementation mistake and not an intentional choice.

As I recall, the historical behavior has been that node run lists are not expanded, but role run lists are expanded. So I think the change is that the copy talking about the run list being expanded has leaked to the nodes view. Some archaeology in git would confirm/deny.


Dan DeLeo
http://tickets.opscode.com/browse/CHEF-2312

KC

On Wed, May 18, 2011 at 6:01 PM, Jason J. W. Williams
jasonjwwilliams@gmail.com wrote:

In the 0.10 WebUI when viewing a node, if you click on the Recipes
link you get an expansion labelled “This is the list of recipes, fully
expanded, as they will be applied to the node in question.”. However,
when my run list only has roles in it, all I see in the Recipes
expansion is the list of roles again…from the "fully expanded"
wording I would have expected a list of the recipes my roles refer to.
Is this a bug or what does “fully expanded” recipes mean in this
context?

Thank you in advance.

-J


#5

BTW, the file that changes is:

chef-server-webui/app/views/nodes/show.html.haml

On Fri, May 20, 2011 at 12:52 PM, KC Braunschweig
kcbraunschweig@gmail.com wrote:

Well I made a change that seems to work in that my 0.10.0 chef server
now shows the expanded run list like the text says. I guess it could
be an open question if this is actually the desired behavior but it
seems better to me. Change is on my github repo
(https://github.com/kcbraunschweig/chef) in the CHEF-2312 branch. I’d
appreciate it if someone could give it a shot for testing purposes.

KC

On Wed, May 18, 2011 at 7:43 PM, Daniel DeLeo dan@kallistec.com wrote:

On Wednesday, May 18, 2011 at 7:30 PM, KC Braunschweig wrote:
Yep, I reported this one a while back. I should probably make some

time to try my hand at a full patch, but the relevant code section is
pretty clear. Would be curious to confirm that this was an
implementation mistake and not an intentional choice.

As I recall, the historical behavior has been that node run lists are not expanded, but role run lists are expanded. So I think the change is that the copy talking about the run list being expanded has leaked to the nodes view. Some archaeology in git would confirm/deny.


Dan DeLeo
http://tickets.opscode.com/browse/CHEF-2312

KC

On Wed, May 18, 2011 at 6:01 PM, Jason J. W. Williams
jasonjwwilliams@gmail.com wrote:

In the 0.10 WebUI when viewing a node, if you click on the Recipes
link you get an expansion labelled “This is the list of recipes, fully
expanded, as they will be applied to the node in question.”. However,
when my run list only has roles in it, all I see in the Recipes
expansion is the list of roles again…from the "fully expanded"
wording I would have expected a list of the recipes my roles refer to.
Is this a bug or what does “fully expanded” recipes mean in this
context?

Thank you in advance.

-J